Skip to content

(MODULES-5228) Move PowerShell Manager template file #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2017

Conversation

glennsarti
Copy link
Contributor

Previously the PowerShell manager template file lived in the root of the
templates directory, however so does the same file in the DSC module which has
caused issues as they diverge. This commit moves the template file to a
PowerShell module specific location so that it should not conflict with any
other modules.

Previously the PowerShell manager template file lived in the root of the
templates directory, however so does the same file in the DSC module which has
caused issues as they diverge.  This commit moves the template file to a
PowerShell module specific location so that it should not conflict with any
other modules.
This commit removes testing on Puppet 4.2.3 as it is no longer supported by
this module, as per the metadata.json.
@jpogran jpogran merged commit 45e36f9 into puppetlabs:master Jul 25, 2017
@Iristyle
Copy link
Contributor

FWIW, I think we should try and namespace all helper code under puppet_x/puppetlabs/powershell, like

puppet_x/puppetlabs/powershell/powershell_manager.rb
puppet_x/puppetlabs/powershell/init_ps1.ps1

Rather than introducing separate namespacing like this PR has done

puppet_x/puppetlabs/powershell/powershell_manager.rb
puppet_x/puppetlabs/templates/powershell/init_ps1.ps1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants