(PDK-1035) Remove the rspec-puppet pin #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverts 5405944 |
|
Original rspec issue was in rodjek/rspec-puppet#498 but has now been resolved. |
|
@rodjek Can you update the commit message to say why you're unpinning. |
rodjek/rspec-puppet#498 has been resolved and updates to rspec-puppet can now be pulled into this module again via the puppet-module metagems.
|
@glennsarti Done and done. This PR doesn't completely revert 5405944 though, just the rspec-puppet related chunks. |
glennsarti
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to getting converted over to use PDK is to make sure that your tests pass with the latest version of rspec-puppet.