Skip to content
This repository was archived by the owner on Aug 4, 2023. It is now read-only.

Improvements for v5 #11

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Improvements for v5 #11

merged 1 commit into from
Jan 15, 2023

Conversation

jamesdbrock
Copy link
Collaborator

@jamesdbrock jamesdbrock commented Jan 10, 2023 •
edited
Loading

Improvements for v5

@jamesdbrock jamesdbrock force-pushed the event-remove branch 2 times, most recently from 85387d5 to 433d7db Compare January 11, 2023 13:19
@jamesdbrock jamesdbrock marked this pull request as ready for review January 11, 2023 13:24
@jamesdbrock jamesdbrock force-pushed the event-remove branch 2 times, most recently from 51bedbe to b9fc445 Compare January 15, 2023 05:37
@jamesdbrock jamesdbrock changed the title event handler cleanup Improvements for v5 Jan 15, 2023
@jamesdbrock jamesdbrock marked this pull request as draft January 15, 2023 05:38
@jamesdbrock jamesdbrock force-pushed the event-remove branch 7 times, most recently from 0356c48 to 4482617 Compare January 15, 2023 06:17
@jamesdbrock jamesdbrock marked this pull request as ready for review January 15, 2023 06:19
@jamesdbrock jamesdbrock force-pushed the event-remove branch 2 times, most recently from c9bb3d5 to 2e060f4 Compare January 15, 2023 06:28
@jamesdbrock
Improvements for v5
dedb52f 
- Change readers to return record instead of `Tuple`.
- Cleanup event handlers.
- Complete reads when stream is closed.
- New `Internal` functions.
@jamesdbrock jamesdbrock merged commit c5d81d3 into main Jan 15, 2023
@jamesdbrock jamesdbrock mentioned this pull request Jan 21, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possible EventEmitter memory leak detected

1 participant

@jamesdbrock