Conditional autoregressive prior example notebook #417
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
conorhassan
changed the title
| @misc{lao2020conditional, | ||
| author = {Lao, Junpeng}, | ||
| title = {Conditional Autoregressive (CAR) model}, | ||
| url = {https://docs.pymc.io/en/v3/pymc-examples/examples/case\_studies/conditional-autoregressive-model.html}, | ||
| year = {2020} | ||
| } |
There was a problem hiding this comment.
This one should not be a bibtex reference but a sphinx cross reference.
| :tags: beginner, tutorial, spatial | ||
| :category: beginner |
There was a problem hiding this comment.
| :tags: beginner, tutorial, spatial | |
| :category: beginner | |
| :tags: spatial | |
| :category: beginner, tutorial |
beginner and tutorial should be categories and not tags.
| import libpysal | ||
| # import bokeh | ||
| from bokeh.plotting import output_notebook |
There was a problem hiding this comment.
I think these two are not dependencies of pymc either.
| language: python | ||
| name: python3 | ||
| substitutions: | ||
| extra_dependencies: bambi seaborn |
There was a problem hiding this comment.
It doesn't look like bambi is used. The libraries here are the ones that should be installed in addition to pip install pymc.
|
Thanks for reviewing @OriolAbril -- Yup you're right there's a ways to go. Hey @conorhassan do you mind converting it to draft?. That's my bad I forgot to mention that yesterday. If it's in draft it pretty much just signals "no intent to merge yet, just putting this up publicly so it's visible and any feedback is welcome". Not in draft signals "Pretty much ready, any last changes that I could/should make before merging this?" Quick Q though @OriolAbril, if you don't mind. This is a follow up from #405. Do you know why pre-commit is failing? We fixed the We tried commiting the changes seen in the current diff made by jupytext, but iirc something else fails, we regenerate the myst file, and we ended up here again. If it's not super obvious, I'll be able to check out the PR and give it another try in a few days. |
|
Just saw I missed the notification for this PR. I don't know why it is complaining. I would try rebasing and seeing how it goes. Otherwise I can try to check out this PR and take a look |
|
Is pre-commit correcting some spelling issues? What I see in pre-commit isnt in the PR diff |
yes, one of the pre-commit jobs is a spellcheck |
|
I just wanted to say I'd like to pick the work on this and make sure this gets merged. I'll dig in tomorrow morning and hopefully send a PR then. |
|
#547 replaces this pr - should be safe to close at any point. |
4 participants
Here is a new notebook using
pm.CARdistribution. The linked issue is #405.The notebook uses parts of the code from the already existing CAR notebook example, but is updated to v4, uses
pm.CARand has a few other bits and pieces.Checklist:
I am getting jupytext pre-commit errors and am unsure how to fix them.