Skip to content

Improve test_locale_calendar_formatweekday of calendar #101377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrehora opened this issue Jan 27, 2023 · 1 comment
Closed

Improve test_locale_calendar_formatweekday of calendar #101377

andrehora opened this issue Jan 27, 2023 · 1 comment

Comments

@andrehora
Copy link
Contributor

andrehora commented Jan 27, 2023 •
edited by bedevere-bot
Loading

It seems that test_locale_calendar_formatweekday of calendar misses some important inputs:

https://github.com/python/cpython/blob/main/Lib/test/test_calendar.py#L567-L578

Specifically, it does not cover a day under different lengths, ie, several common cases in which 1 <= length <= 10, which can change the weekday formatting.

Linked PRs
@bedevere-bot bedevere-bot mentioned this issue Jan 27, 2023
Merged
terryjreedy added a commit that referenced this issue Mar 15, 2023
@andrehora @blurb-it @terryjreedy
gh-101377: improving test_locale_calendar_formatweekday of calendar (#…
5e0865f 
…101378)


---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Mar 15, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 15, 2023
@andrehora @blurb-it
@terryjreedy @miss-islington
pythongh-101377: improving test_locale_calendar_formatweekday of cale…
c019bb6 
…ndar (pythonGH-101378)

---------

(cherry picked from commit 5e0865f)

Co-authored-by: Andre Hora <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Mar 15, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 15, 2023
@andrehora @blurb-it
@terryjreedy @miss-islington
pythongh-101377: improving test_locale_calendar_formatweekday of cale…
3f79894 
…ndar (pythonGH-101378)

---------

(cherry picked from commit 5e0865f)

Co-authored-by: Andre Hora <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington added a commit that referenced this issue Mar 15, 2023
@miss-islington @andrehora
@blurb-it @terryjreedy
gh-101377: improving test_locale_calendar_formatweekday of calendar (G…
6f4df72 
…H-101378)

---------

(cherry picked from commit 5e0865f)

Co-authored-by: Andre Hora <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington added a commit that referenced this issue Mar 15, 2023
@miss-islington @andrehora
@blurb-it @terryjreedy
gh-101377: improving test_locale_calendar_formatweekday of calendar (G…
8aa07b9 
…H-101378)

---------

(cherry picked from commit 5e0865f)

Co-authored-by: Andre Hora <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
@hauntsaninja
Copy link
Contributor

Thank you! :-)

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@andrehora @blurb-it
@terryjreedy @Fidget-Spinner
pythongh-101377: improving test_locale_calendar_formatweekday of cale…
669c82a 
…ndar (python#101378)


---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@andrehora @blurb-it
@terryjreedy @warsaw
pythongh-101377: improving test_locale_calendar_formatweekday of cale…
c2f03e5 
…ndar (python#101378)


---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrehora @hauntsaninja