Skip to content

Tkinter: return value of mp_init() should not be ignored #106350

Closed
@chrstphrchvz

Description

@chrstphrchvz

An mp_int structure is usable only if mp_init() returns MP_OKAY; mp_init() may return MP_MEM if it fails to allocate memory (see https://github.com/libtom/libtommath/blob/v1.2.0/bn_mp_init.c#L12).

mp_init() must be checked to avoid a warning when compiling against standalone libtommath headers (rather than Tcl-bundled libtommath):

./Modules/_tkinter.c:908:5: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
    mp_init(&bigValue);
    ^~~~~~~ ~~~~~~~~~
1 warning generated.

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibPython modules in the Lib dirtopic-tkintertype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions