_testinternalcapi.get_counter_optimizer() segfaults

[iritkatriel]

Crash report

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Output from running 'python -VV' on the command line:

Python 3.13.0a0 (heads/main:13a00078b8, Aug 31 2023, 18:44:11) [Clang 14.0.3 (clang-1403.0.22.14.1)]

What happened?

# cat zz.py                        
__lltrace__ = True

import _testinternalcapi

def f():
    _testinternalcapi.get_counter_optimizer()

f()

Error messages

% ./python.exe zz.py               

Resuming frame for 'f' in module '__main__'
    stack=[]
0: RESUME 0
    stack=[]
2: LOAD_GLOBAL 0
    stack=[<module at 0x1073f2150>]
12: LOAD_ATTR 2
    stack=[<builtin_function_or_method at 0x1073f3650>]
32: PUSH_NULL
    stack=[<builtin_function_or_method at 0x1073f3650>, <nil>]
34: CALL 0
    stack=[<Counter optimizer at 0x1073a47c0>]
42: POP_TOP
zsh: segmentation fault  ./python.exe zz.py

Linked PRs

• gh-108727: Fix segfault due to missing tp_dealloc definition for CounterOptimizer_Type #108734

[iritkatriel]

This seems to fix it:

--- a/Python/optimizer.c
+++ b/Python/optimizer.c
@@ -289,6 +289,7 @@ static PyTypeObject CounterOptimizer_Type = {
     .tp_itemsize = 0,
     .tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_DISALLOW_INSTANTIATION,
     .tp_methods = counter_methods,
+    .tp_dealloc = (destructor)PyObject_Del,
 };
 
 PyObject *