Skip to content

Speed up pathlib.PurePath.[is_]relative_to() #111429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
barneygale opened this issue Oct 28, 2023 · 1 comment
Closed

Speed up pathlib.PurePath.[is_]relative_to() #111429

barneygale opened this issue Oct 28, 2023 · 1 comment
Labels
performance Performance or resource usage topic-pathlib

Comments

@barneygale
Copy link
Contributor

barneygale commented Oct 28, 2023 •
edited by bedevere-app bot
Loading

Both methods call self.with_segments() unconditionally. This can be skipped if the other argument is already an instance of PurePath, and no further (deprecated) positional arguments are given.

Also, relative_to() can inline the core of the is_relative_to() check to avoid the type/deprecated args checks.

Linked PRs
@barneygale barneygale added performance Performance or resource usage topic-pathlib labels Oct 28, 2023
barneygale added a commit to barneygale/cpython that referenced this issue Oct 28, 2023
@barneygale
pythonGH-111429: Speed up pathlib.PurePath.[is_]relative_to()
6e93540
@bedevere-app bedevere-app bot mentioned this issue Oct 28, 2023
Merged
barneygale added a commit that referenced this issue Nov 12, 2023
@barneygale
GH-111429: Speed up pathlib.PurePath.[is_]relative_to() (#111431)
d7cef7b
@barneygale
Copy link
Contributor Author

barneygale commented Nov 12, 2023 •
edited
Loading

Resolved in 3.13 / 6e93540 / #111431

aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@barneygale @aisk
pythonGH-111429: Speed up pathlib.PurePath.[is_]relative_to() (pyth…
479427c 
…on#111431)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@barneygale @Glyphack
pythonGH-111429: Speed up pathlib.PurePath.[is_]relative_to() (pyth…
1e89dcf 
…on#111431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance or resource usage topic-pathlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barneygale