Skip to content

Free-threaded dictionary lookups aren't marking objects as weakref'd #124642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DinoV opened this issue Sep 26, 2024 · 0 comments
Closed

Free-threaded dictionary lookups aren't marking objects as weakref'd #124642

DinoV opened this issue Sep 26, 2024 · 0 comments
Assignees
@DinoV
Labels
topic-free-threading type-bug An unexpected behavior, bug, or error

Comments

@DinoV
Copy link
Contributor

DinoV commented Sep 26, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Dictionaries have a fast path which doesn't lock on lookups and a slow path which does. The intention is that the fast-path will succeed after the first slow-path lookup has been passed. But currently we're not parking objects as shared so it always fails.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@DinoV DinoV added type-bug An unexpected behavior, bug, or error topic-free-threading labels Sep 26, 2024
@DinoV DinoV self-assigned this Sep 26, 2024
@bedevere-app bedevere-app bot mentioned this issue Sep 26, 2024
Merged
DinoV added a commit that referenced this issue Sep 30, 2024
@DinoV
gh-124642: Dictionaries aren't marking objects as weakref'd (#124643)
077e7ef 
Dictionaries aren't marking objects as weakref'd
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 30, 2024
@DinoV @miss-islington
pythongh-124642: Dictionaries aren't marking objects as weakref'd (py…
8b9dc13 
…thonGH-124643)

Dictionaries aren't marking objects as weakref'd
(cherry picked from commit 077e7ef)

Co-authored-by: Dino Viehland <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Sep 30, 2024
Merged
Yhg1s pushed a commit that referenced this issue Sep 30, 2024
@miss-islington @DinoV
[3.13] gh-124642: Dictionaries aren't marking objects as weakref'd (G…
44ba11a 
…H-124643) (#124798)

gh-124642: Dictionaries aren't marking objects as weakref'd (GH-124643)

Dictionaries aren't marking objects as weakref'd
(cherry picked from commit 077e7ef)

Co-authored-by: Dino Viehland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DinoV DinoV

Labels
topic-free-threading type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DinoV @colesbury