Skip to content

Embeddable distribution for 3.13 includes Tcl/Tk DLL files #126074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lir-ht opened this issue Oct 28, 2024 · 2 comments
Closed

Embeddable distribution for 3.13 includes Tcl/Tk DLL files #126074

lir-ht opened this issue Oct 28, 2024 · 2 comments
Assignees
@zooba
Labels
3.13 bugs and security fixes OS-windows type-bug An unexpected behavior, bug, or error

Comments

@lir-ht
Copy link

lir-ht commented Oct 28, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

I noticed that the size of the embeddable distribution for Windows increased by roughly 2 MB between 3.12 and 3.13 (in the 32-bit distribution when unpacked), despite the PEP 594 dead batteries removal. This turns out to be in part because 3.13, unlike earlier versions, includes the files tcl86t.dll and tk86t.dll which together take up around 2.6 MB.

Should these DLL files really be included in the embeddable distribution? Since the _tkinter module and the rest of Tkinter isn't included, it doesn't seem like these files are of any use.

CPython versions tested on:

3.13

Operating systems tested on:

Windows

Linked PRs
@lir-ht lir-ht added the type-bug An unexpected behavior, bug, or error label Oct 28, 2024
@zooba zooba self-assigned this Oct 29, 2024
@zooba zooba added the 3.13 bugs and security fixes label Oct 29, 2024
zooba added a commit to zooba/cpython that referenced this issue Oct 29, 2024
@zooba
pythongh-126074: Removes unnecessary DLLs from embeddable package
5efce1e
@bedevere-app bedevere-app bot mentioned this issue Oct 29, 2024
Merged
zooba added a commit that referenced this issue Nov 5, 2024
@zooba
gh-126074: Removes unnecessary DLLs from embeddable package (GH-126143)
f51fd84
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 5, 2024
@zooba @miss-islington
pythongh-126074: Removes unnecessary DLLs from embeddable package (py…
290a5b2 
…thonGH-126143)

(cherry picked from commit f51fd84)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Nov 5, 2024
Merged
zooba added a commit that referenced this issue Nov 5, 2024
@miss-islington @zooba
gh-126074: Removes unnecessary DLLs from embeddable package (GH-126143)
88e0131 
(cherry picked from commit f51fd84)

Co-authored-by: Steve Dower <[email protected]>
@rruuaanng
Copy link
Contributor

Can this issue be closed? It seems to have been completed ;)

@zware
Copy link
Member

zware commented Nov 19, 2024

Thanks for the report, @lir-ht! This will be fixed in v3.13.1.

@zware zware closed this as completed Nov 19, 2024
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@zooba @picnixz
pythongh-126074: Removes unnecessary DLLs from embeddable package (py…
b49f837 
…thonGH-126143)
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@zooba @ebonnal
pythongh-126074: Removes unnecessary DLLs from embeddable package (py…
351697b 
…thonGH-126143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zooba zooba

Labels
3.13 bugs and security fixes OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ericvsmith @zooba @lir-ht @zware @rruuaanng