Skip to content

iOS clang aliases crash with "invalid directory name" error if called with arguments having spaces #127434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FeodorFitsner opened this issue Nov 30, 2024 · 4 comments · Fixed by #127575
Closed

iOS clang aliases crash with "invalid directory name" error if called with arguments having spaces #127434

FeodorFitsner opened this issue Nov 30, 2024 · 4 comments · Fixed by #127575
Assignees
@freakboy3742
Labels
build The build process and cross-build OS-ios type-bug An unexpected behavior, bug, or error

Comments

@FeodorFitsner
Copy link
Contributor

FeodorFitsner commented Nov 30, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

While doing cross-compilation of Python packages for iOS calling arm64-apple-ios-clang script (and other aliases as well) fails if arguments contain spaces, for example:

arm64-apple-ios-clang -DPACKAGE_TARNAME="aaa" -DPACKAGE_STRING="aaa 1.2.2" -c -o src/main.o src/main.c

gives clang: invalid directory name: '1.2.2"' error.

To fix that $@ inside script should be wrapped with quotes: "$@".

I'm going to make PR.

CPython versions tested on:

3.12

Operating systems tested on:

macOS

Linked PRs
@FeodorFitsner FeodorFitsner added the type-bug An unexpected behavior, bug, or error label Nov 30, 2024
@ZeroIntensity ZeroIntensity added build The build process and cross-build OS-ios labels Nov 30, 2024
@ZeroIntensity
Copy link
Member

cc @freakboy3742

@FeodorFitsner
Copy link
Contributor Author

Original issue: beeware/Python-Apple-support#241 (review)

@freakboy3742 freakboy3742 self-assigned this Nov 30, 2024
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
@freakboy3742
Copy link
Contributor

@FeodorFitsner Were you planning to submit the PR you submitted against Python-Apple-support to CPython?

@FeodorFitsner
Copy link
Contributor Author

Yes, I'm going to make a PR.

@FeodorFitsner FeodorFitsner mentioned this issue Dec 3, 2024
Merged
freakboy3742 pushed a commit that referenced this issue Dec 5, 2024
@FeodorFitsner
gh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow arguments …
6cf7794 
…with spaces (#127575)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
freakboy3742 pushed a commit to freakboy3742/cpython that referenced this issue Dec 5, 2024
@FeodorFitsner @freakboy3742
[3.13] pythongh-127434: Fix iOS xcrun --sdk clang/ar scripts to all…
336e62d 
…ow arguments with spaces (pythonGH-127575)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
(cherry picked from commit 6cf7794)

Co-authored-by: Feodor Fitsner <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Dec 5, 2024
Merged
freakboy3742 added a commit that referenced this issue Dec 5, 2024
@freakboy3742 @FeodorFitsner
[3.13] gh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow arg…
1182c64 
…uments with spaces (GH-127575) (#127624)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
(cherry picked from commit 6cf7794)

Co-authored-by: Feodor Fitsner <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Dec 13, 2024
@freakboy3742 @FeodorFitsner
[3.9] pythongh-127434: Fix iOS xcrun --sdk clang/ar scripts to allo…
3f06038 
…w arguments with spaces (pythonGH-127575) (python#127624)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
(cherry picked from commit 6cf7794)

Co-authored-by: Feodor Fitsner <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Dec 13, 2024
@freakboy3742 @FeodorFitsner
[3.10] pythongh-127434: Fix iOS xcrun --sdk clang/ar scripts to all…
bb580fb 
…ow arguments with spaces (pythonGH-127575) (python#127624)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
(cherry picked from commit 6cf7794)

Co-authored-by: Feodor Fitsner <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Dec 13, 2024
@freakboy3742 @FeodorFitsner
[3.12] pythongh-127434: Fix iOS xcrun --sdk clang/ar scripts to all…
2429749 
…ow arguments with spaces (pythonGH-127575) (python#127624)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
(cherry picked from commit 6cf7794)

Co-authored-by: Feodor Fitsner <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Dec 13, 2024
@freakboy3742 @FeodorFitsner
[3.13] pythongh-127434: Fix iOS xcrun --sdk clang/ar scripts to all…
cf6430e 
…ow arguments with spaces (pythonGH-127575) (python#127624)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
(cherry picked from commit 6cf7794)

Co-authored-by: Feodor Fitsner <[email protected]>
freakboy3742 pushed a commit to freakboy3742/cpython that referenced this issue Dec 13, 2024
@FeodorFitsner @freakboy3742
pythongh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow argu…
e750f21 
…ments with spaces (python#127575)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Dec 13, 2024
@freakboy3742 @FeodorFitsner
[3.11] pythongh-127434: Fix iOS xcrun --sdk clang/ar scripts to all…
a4cde03 
…ow arguments with spaces (pythonGH-127575) (python#127624)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
(cherry picked from commit 6cf7794)

Co-authored-by: Feodor Fitsner <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@FeodorFitsner @srinivasreddy
pythongh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow argu…
1523b9d 
…ments with spaces (python#127575)

Added shell escaping to ensure iOS compiler shims can accept arguments with spaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freakboy3742 freakboy3742

Labels
build The build process and cross-build OS-ios type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow arguments with spaces flet-dev/cpython
3 participants
@freakboy3742 @FeodorFitsner @ZeroIntensity