Skip to content

Solaris: fix ossaudio support #91734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kulikjak opened this issue Apr 20, 2022 · 0 comments · Fixed by #91735
Closed

Solaris: fix ossaudio support #91734

kulikjak opened this issue Apr 20, 2022 · 0 comments · Fixed by #91735
Labels
type-bug An unexpected behavior, bug, or error

Comments

@kulikjak
Copy link
Contributor

ossaudio module needs an additional patch in order to compile it on Solaris because not all ioctls are supported (specifically SNDCTL_DSP_MAPINBUF and SNDCTL_DSP_MAPOUTBUF).

Other OpenSolaris forks are using the same patch as we do:
Oracle Solaris, OpenIndiana, OmniOS

(This is similar to recent #90211 made for NetBSD).
@kulikjak kulikjak added the type-feature A feature request or enhancement label Apr 20, 2022
@kulikjak kulikjak mentioned this issue Apr 20, 2022
Merged
serhiy-storchaka pushed a commit that referenced this issue Apr 20, 2022
@kulikjak
gh-91734: Fix ossaudio support on Solaris (GH-91735)
4420faf
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 20, 2022
@kulikjak @miss-islington
pythongh-91734: Fix ossaudio support on Solaris (pythonGH-91735)
816ddfb 
(cherry picked from commit 4420faf)

Co-authored-by: Jakub Kulík <[email protected]>
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error and removed type-feature A feature request or enhancement labels Apr 20, 2022
miss-islington added a commit that referenced this issue Apr 20, 2022
@miss-islington @kulikjak
gh-91734: Fix ossaudio support on Solaris (GH-91735)
923ef87 
(cherry picked from commit 4420faf)

Co-authored-by: Jakub Kulík <[email protected]>
miss-islington added a commit that referenced this issue Apr 20, 2022
@miss-islington @kulikjak
gh-91734: Fix ossaudio support on Solaris (GH-91735)
56c2d08 
(cherry picked from commit 4420faf)

Co-authored-by: Jakub Kulík <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this issue Jun 2, 2022
@miss-islington @kulikjak @hello-adam
pythongh-91734: Fix ossaudio support on Solaris (pythonGH-91735)
bb33059 
(cherry picked from commit 4420faf)

Co-authored-by: Jakub Kulík <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-91734: fix ossaudio support on Solaris kulikjak/cpython
2 participants
@serhiy-storchaka @kulikjak