Skip to content

[3.7] gh-100001: Omit control characters in http.server stderr logs. (GH-100002) #100034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2022
Merged

[3.7] gh-100001: Omit control characters in http.server stderr logs. (GH-100002) #100034

merged 3 commits into from
Dec 5, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 5, 2022 •
edited by bedevere-bot
Loading

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith [email protected]

@gpshead @miss-islington
pythongh-100001: Omit control characters in http.server stderr logs. (p…
69f5f37 
…ythonGH-100002)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>
This was referenced Dec 5, 2022
Closed
Merged
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

ned-deily
ned-deily requested changes Dec 5, 2022
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

gpshead
gpshead approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'm applying the doc fixup to the other PRs.

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@ned-deily ned-deily merged commit b5bdf6a into python:3.7 Dec 5, 2022
@miss-islington miss-islington deleted the backport-d8ab0a4-3.7 branch December 5, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@ned-deily ned-deily ned-deily approved these changes

Assignees

@ned-deily ned-deily

Labels
release-blocker type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @bedevere-bot @gpshead @ned-deily