Skip to content

gh-100110: Specialize FOR_ITER for tuples #100109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Dec 8, 2022

@netlify
Copy link

netlify bot commented Dec 8, 2022

Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit e3504e7
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6391d802c8b963000994af92

@Fidget-Spinner Fidget-Spinner changed the title Specialize FOR_ITER for tuples gh-100110: Specialize FOR_ITER for tuples Dec 8, 2022
@markshannon
Copy link
Member

I'm not sure that I entirely trust those stats, yet.
They are probably right though, and I guess we can revert this if the stats prove to be wrong.

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Have you attempted to benchmark this?

@Fidget-Spinner
Copy link
Member Author

Looks good. Have you attempted to benchmark this?

No. It's just one specialisation. I doubt anything in pyperformance will change.

@markshannon
Copy link
Member

markshannon commented Dec 8, 2022

I'm running the stats on it.
Partly to see if this PR makes the expected difference, and partly just to see if the stats workflow does what I expect.

@markshannon
Copy link
Member

The stats show what I would expect. No specialization failures for tuples, and an increase of hit rates for FOR_ITER from about 66% to 79%.

@markshannon markshannon merged commit 748c6c0 into python:main Dec 9, 2022
@Fidget-Spinner Fidget-Spinner deleted the for_iter_tuple branch December 10, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants