-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-82052: Don't send partial UTF-8 sequences to the Windows API #101103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah, I don't think this can be tested without mocking native APIs. And while I think we can do that now (for console stuff), we don't have the infrastructure set up for it, and no need to add it for this. I approve this, so merge whenever you're happy. |
Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-101107 is a backport of this pull request to the 3.11 branch. |
GH-101108 is a backport of this pull request to the 3.10 branch. |
…pythonGH-101103) Don't send partial UTF-8 sequences to the Windows API (cherry picked from commit f34176b) Co-authored-by: Paul Moore <[email protected]>
…pythonGH-101103) Don't send partial UTF-8 sequences to the Windows API (cherry picked from commit f34176b) Co-authored-by: Paul Moore <[email protected]>
…01103) Don't send partial UTF-8 sequences to the Windows API (cherry picked from commit f34176b) Co-authored-by: Paul Moore <[email protected]>
…01103) Don't send partial UTF-8 sequences to the Windows API (cherry picked from commit f34176b) Co-authored-by: Paul Moore <[email protected]>
Fixes #82052
This doesn't include a test, as I'm not sure how I would write a test for it. The only reproducer I am aware of involves sending output to the console screen and visually inspecting it. I've validated that this PR fixes the issue by doing that test, but it's not something I know how to automate.