Skip to content

GH-102700: allow built-in modules to be submodules #103162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 6, 2023
Merged

GH-102700: allow built-in modules to be submodules #103162

merged 6 commits into from
Apr 6, 2023

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Apr 1, 2023 •
edited by bedevere-bot
Loading

@brettcannon brettcannon self-assigned this Apr 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 1, 2023
Closed
arhadthedev
arhadthedev reviewed Apr 1, 2023
View reviewed changes
@brettcannon brettcannon added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Apr 4, 2023
@brettcannon brettcannon removed the needs backport to 3.10 only security fixes label Apr 6, 2023
@brettcannon brettcannon merged commit 5d08c3f into python:main Apr 6, 2023
@brettcannon brettcannon deleted the builtin-submodules branch April 6, 2023 21:19
@miss-islington
Copy link
Contributor

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @brettcannon, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 5d08c3ff7d89ca11556f18663a372f6c12435504 3.11

@brettcannon brettcannon added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Apr 6, 2023
@miss-islington
Copy link
Contributor

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-103322 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2023
@brettcannon @miss-islington
pythonGH-102700: allow built-in modules to be submodules (pythonGH-10…
e807b79 
…3162)

(cherry picked from commit 5d08c3f)

Co-authored-by: Brett Cannon <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 6, 2023
brettcannon added a commit that referenced this pull request Apr 6, 2023
@miss-islington @brettcannon
[3.11] GH-102700: allow built-in modules to be submodules (GH-103162) (…
123680f 
…GH-103322)

GH-102700: allow built-in modules to be submodules (GH-103162)
(cherry picked from commit 5d08c3f)

Co-authored-by: Brett Cannon <[email protected]>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@brettcannon @warsaw
pythonGH-102700: allow built-in modules to be submodules (pythonGH-10…
09794e9 
…3162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

Assignees

@brettcannon brettcannon

Labels
topic-importlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brettcannon @miss-islington @bedevere-bot @arhadthedev