-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-105052:update timeit function's description #105060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…influence by timer parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR could have waited for more discussion on the issue. See this comment for what I think the most important change for this issue should be, and where.
The Timer docstring has an obsolete and now wrong statement about the timer that should be deleted: ; the timer function is platform-dependent (see the module doc string)
Misc/NEWS.d/next/Documentation/2023-05-29-14-10-24.gh-issue-105052.MGFwbm.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thanks @Cherrymelon for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
GH-108534 is a backport of this pull request to the 3.12 branch. |
--------- Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit 7096a2b) Co-authored-by: R <[email protected]>
GH-108535 is a backport of this pull request to the 3.11 branch. |
--------- Co-authored-by: Terry Jan Reedy <[email protected]> (cherry picked from commit 7096a2b) Co-authored-by: R <[email protected]>
…08535) --------- Co-authored-by: Terry Jan Reedy [email protected] Co-authored-by: R <[email protected]> (cherry picked from commit 7096a2b)
Update time unit description in
timeit
function and add note to timeit doc pagetimeit.Timer.timeit
should mention that the return value depends on the timer #105052