Skip to content

gh-106529: Support FOR_ITER specializations as uops #106542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+287 −194
Closed

gh-106529: Support FOR_ITER specializations as uops #106542

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c59fd5
Support FOR_ITER specializations as uops
gvanrossum Jul 8, 2023
df61257
Clean up TestUops a bit
gvanrossum Jul 8, 2023
e6c6603
Add test for FOR_ITER_RANGE
gvanrossum Jul 8, 2023
4e9c1ea
More small test cleanups
gvanrossum Jul 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
More small test cleanups
  • Loading branch information
@gvanrossum
gvanrossum committed Jul 9, 2023
commit 4e9c1eab09e8783b3c7d342fbb634b6f58883c6c
17 changes: 9 additions & 8 deletions Lib/test/test_capi/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2347,11 +2347,12 @@ def func():

@contextlib.contextmanager
def temporary_optimizer(opt):
old_opt = _testinternalcapi.get_optimizer()
_testinternalcapi.set_optimizer(opt)
try:
yield
finally:
_testinternalcapi.set_optimizer(None)
_testinternalcapi.set_optimizer(old_opt)


@contextlib.contextmanager
Expand Down Expand Up @@ -2420,8 +2421,8 @@ def long_loop():
self.assertEqual(opt.get_count(), 10)



def get_first_executor(code):
def get_first_executor(func):
code = func.__code__
co_code = code.co_code
JUMP_BACKWARD = opcode.opmap["JUMP_BACKWARD"]
for i in range(0, len(co_code), 2):
Expand All @@ -2446,7 +2447,7 @@ def testfunc(x):
with temporary_optimizer(opt):
testfunc(1000)

ex = get_first_executor(testfunc.__code__)
ex = get_first_executor(testfunc)
self.assertIsNotNone(ex)
uops = {opname for opname, _ in ex}
self.assertIn("SAVE_IP", uops)
Expand Down Expand Up @@ -2487,11 +2488,11 @@ def many_vars():

opt = _testinternalcapi.get_uop_optimizer()
with temporary_optimizer(opt):
ex = get_first_executor(many_vars.__code__)
ex = get_first_executor(many_vars)
self.assertIsNone(ex)
many_vars()

ex = get_first_executor(many_vars.__code__)
ex = get_first_executor(many_vars)
self.assertIsNotNone(ex)
self.assertIn(("LOAD_FAST", 259), list(ex))

Expand All @@ -2512,7 +2513,7 @@ def testfunc(x):
with temporary_optimizer(opt):
testfunc(10)

ex = get_first_executor(testfunc.__code__)
ex = get_first_executor(testfunc)
self.assertIsNotNone(ex)
uops = {opname for opname, _ in ex}
self.assertIn("UNPACK_SEQUENCE", uops)
Expand All @@ -2527,7 +2528,7 @@ def testfunc(x):
with temporary_optimizer(opt):
testfunc(10)

ex = get_first_executor(testfunc.__code__)
ex = get_first_executor(testfunc)
self.assertIsNotNone(ex)
uops = {opname for opname, _ in ex}
self.assertIn("FOR_ITER_RANGE", uops)
Expand Down