gh-106962: Detect mpicc in configure.ac #106961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hen compiling Python with the MPI wrapper around the GNU C-compilers: mpicc, the configure script that determines the compiler options sees mpicc as the intel compiler because of the 'icc' in the name, and applies the fp-model strict option to the arguments, which is invalid syntax for GCC, causing multiple compile time errors with recent GCC versions: gcc: error: unrecognized command-line option ‘-fp-model’; did you mean ‘-fipa-modref’? By first filtering out the mpicc compiler case, this error is prevented.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
This does not only apply to configure.ac, but exactly the same thing to the main configure script. Have created issue number: 106962 |
|
You also need to regenerate |
erlend-aasland
changed the title
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
erlend-aasland
approved these changes
Jul 22, 2023
| @@ -2656,6 +2656,9 @@ yes) | |||
| esac | |||
|
|
|||
| case "$CC" in | |||
| *mpicc*) | |||
| CFLAGS_NODIST="$CFLAGS_NODIST" | |||
There was a problem hiding this comment.
Strictly, this line is not needed; we could for example do:
Suggested change
| CFLAGS_NODIST="$CFLAGS_NODIST" |
I'm also fine with the current line.
|
Thanks @LukasvdWiel for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-107081 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 22, 2023
Don't let autoconf mistake MPI compilers for Intel compilers; filter out the MPI case to prevent Intel specific options from being applied. (cherry picked from commit 9a6b278) Co-authored-by: Lukas van de Wiel <[email protected]>
erlend-aasland
pushed a commit
that referenced
this pull request
Jul 23, 2023
Don't let autoconf mistake MPI compilers for Intel compilers; filter out the MPI case to prevent Intel specific options from being applied. (cherry picked from commit 9a6b278) Co-authored-by: Lukas van de Wiel <[email protected]>
jtcave
pushed a commit
to jtcave/cpython
that referenced
this pull request
Jul 23, 2023
Don't let autoconf mistake MPI compilers for Intel compilers; filter out the MPI case to prevent Intel specific options from being applied.
mementum
pushed a commit
to mementum/cpython
that referenced
this pull request
Jul 23, 2023
Don't let autoconf mistake MPI compilers for Intel compilers; filter out the MPI case to prevent Intel specific options from being applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title:
Fixing Python configure script to handle MPI wrapper around GCC compiler.
summary of the changes made:
Added mpicc to the list of possible compilers that the configure script checks for.
Issue: gh-106962
Full description:
When compiling Python with the MPI wrapper around the GNU C-compilers: mpicc, the configure script that determines the compiler options sees mpicc as the intel compiler because of the 'icc' in the name, and applies the fp-model strict option to the arguments, which is invalid syntax for GCC, causing multiple compile time errors with recent GCC versions:
gcc: error: unrecognized command-line option ‘-fp-model’; did you mean ‘-fipa-modref’?
By first filtering out the mpicc compiler case, this error is prevented.