gh-110864: Fix _PyArg_UnpackKeywordsWithVararg overwriting vararg with NULL
#110868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vararg` with `NULL` in some cases
erlend-aasland
approved these changes
Oct 16, 2023
|
Thanks @sobolevn for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @sobolevn and @erlend-aasland, I could not cleanly backport this to |
erlend-aasland
changed the title
_PyArg_UnpackKeywordsWithVararg overwritting vararg with NULL_PyArg_UnpackKeywordsWithVararg overwriting vararg with NULL
|
@sobolevn @erlend-aasland Does this still need a 3.12 backport? If not, let's close #110864. |
|
cc. @JelleZijlstra who added the backport label. |
|
Ideally this should be fixed in 3.12 too, but if that's difficult to do, we can probably forget about it. The surface bug was already fixed in 3.12. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix feels like a hack (basically as any other argument parsing fix) :)
But, it seems to be semantically correct, do its job, pass tests.