gh-111808: Fix recursion error on WASM in test_typing
#111819
Merged
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
gvanrossum,
JelleZijlstra and
AlexWaygood
as code owners
JelleZijlstra
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Fine with me, but will leave to @brettcannon to confirm this fixes WASI.
brettcannon
approved these changes
Nov 7, 2023
|
That works!
The easiest way to do it right now is to modify https://github.com/python/cpython/blob/main/Tools/wasm/build_wasi.sh to do a pydebug build (the |
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Nov 8, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brettcannon is that reasonable to use
25here? Many other tests do this.And is there a way to test that WASM build now works?
test_forward_recursion_actuallyfromtest_typingtriggers stack overflow protections for a debug build under WASI #111808