gh-112358: Fix Python 3.12 regression with subclassing struct.Struct. #112424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexWaygood Thanks for alerting me to this issue. Would you be willing to review the fix? |
AlexWaygood
reviewed
Nov 26, 2023
AlexWaygood
approved these changes
Nov 26, 2023
Okay, noted for the future. :-)
Ah yes, I should have elaborated in the PR description (and I've belatedly updated the PR description): the first commit is indeed a clean revert ( Thank you for reviewing! |
|
Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @mdickinson, I could not cleanly backport this to |
|
GH-112426 is a backport of this pull request to the 3.12 branch. |
mdickinson
added a commit
to mdickinson/cpython
that referenced
this pull request
Nov 26, 2023
…truct.Struct. (pythonGH-112424) Revert commit c8c0afc (PR pythonGH-94532), which moved `struct.Struct` initialisation from `Struct.__init__` to `Struct.__new__`. This caused issues with code in the wild that subclasses `struct.Struct`.. (cherry picked from commit 9fe6034) Co-authored-by: Mark Dickinson <[email protected]>
mdickinson
added a commit
that referenced
this pull request
Nov 27, 2023
…Struct (GH-112424) (#112426) * [3.12] gh-112358: Fix Python 3.12 regression with subclassing struct.Struct. (GH-112424) Revert commit c8c0afc (PR GH-94532), which moved `struct.Struct` initialisation from `Struct.__init__` to `Struct.__new__`. This caused issues with code in the wild that subclasses `struct.Struct`.. (cherry picked from commit 9fe6034) Co-authored-by: Mark Dickinson <[email protected]> * Remove unrelated test
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…truct. (python#112424) Revert commit c8c0afc (PR python#94532), which moved `struct.Struct` initialisation from `Struct.__init__` to `Struct.__new__`. This caused issues with code in the wild that subclasses `struct.Struct`.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…truct. (python#112424) Revert commit c8c0afc (PR python#94532), which moved `struct.Struct` initialisation from `Struct.__init__` to `Struct.__new__`. This caused issues with code in the wild that subclasses `struct.Struct`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit c8c0afc (PR #94532), which caused issues with code in the wild that subclasses
struct.Struct.Note for reviewers: the first commit contains no manual changes: it's the result of a
git revert c8c0afcfollowed bypython Tools/clinic/clinic.py -f Modules/_struct.cto regenerate the argument clinic code.