gh-112720: Move dis's cache output code to the Formatter, labels lookup to the arg_resolver. Reduce the number of parameters passed around. #113108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion instead of creating fake Instructions to represent it
…at access internals.
iritkatriel
changed the title
markshannon
reviewed
Dec 14, 2023
| @@ -113,7 +113,14 @@ def dis(x=None, *, file=None, depth=None, show_caches=False, adaptive=False, | |||
| elif hasattr(x, 'co_code'): # Code object | |||
| _disassemble_recursive(x, file=file, depth=depth, show_caches=show_caches, adaptive=adaptive, show_offsets=show_offsets) | |||
| elif isinstance(x, (bytes, bytearray)): # Raw bytecode | |||
| _disassemble_bytes(x, file=file, show_caches=show_caches, show_offsets=show_offsets) | |||
There was a problem hiding this comment.
Why does this need different handling now?
There was a problem hiding this comment.
It's not different handling, just different argument types. If we pass around the arg_resolver and formatter then we can plug in different implementations of them.
markshannon
approved these changes
Dec 15, 2023
corona10
pushed a commit
to corona10/cpython
that referenced
this pull request
Dec 15, 2023
…s lookup to the arg_resolver. Reduce the number of parameters passed around. (python#113108)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…s lookup to the arg_resolver. Reduce the number of parameters passed around. (python#113108)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…s lookup to the arg_resolver. Reduce the number of parameters passed around. (python#113108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the refactor of dis.