Skip to content

gh-75128: Ignore EADDRNOTAVAIL error in asyncio.BaseEventLoop.create_server() #114420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2024
Merged

gh-75128: Ignore EADDRNOTAVAIL error in asyncio.BaseEventLoop.create_server() #114420

merged 1 commit into from
Jan 22, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 22, 2024 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 22, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jan 22, 2024
Closed
@serhiy-storchaka
Copy link
Member Author

It is actually a 6.5 years old patch by @pitrou which was not yet merged perhaps due to oversight.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 0c836ae 🤖

The command will test the builders whose names match following regular expression: AMD64 Arch Linux

The builders matched are:

  • AMD64 Arch Linux Asan PR
  • AMD64 Arch Linux TraceRefs PR
  • AMD64 Arch Linux Asan Debug PR
  • AMD64 Arch Linux Usan PR
  • AMD64 Arch Linux VintageParser PR
  • AMD64 Arch Linux Perf PR

@pitrou
Copy link
Member

pitrou commented Jan 22, 2024 •
edited
Loading

Well I lost track of this and I haven't done any network programming in a long time, so I don't feel qualified to review this anymore, sorry :-(

@serhiy-storchaka
Copy link
Member Author

The change looks reasonable to me, it got positive feedback in the issue, and it fixes the remaining failures on buildbots. So I'm going to merge it.

gvanrossum
gvanrossum approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Make sure to add Antoine in a Co-Authored-By header.

@serhiy-storchaka
Copy link
Member Author

LGTM, thanks! Make sure to add Antoine in a Co-Authored-By header.

Yes, of course, it is Antoine's patch. I only added one line (log warning only in debugging, as in other cases) and a NEWS entry. The patch was good from the start and did not need a correction.

@serhiy-storchaka serhiy-storchaka merged commit a53e56e into python:main Jan 22, 2024
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the eaddrnotavail_asyncio branch January 22, 2024 16:40
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2024
@serhiy-storchaka @pitrou @miss-islington
pythongh-75128: Ignore EADDRNOTAVAIL error in asyncio.BaseEventLoop.c…
0d12dee 
…reate_server() (pythonGH-114420)

(cherry picked from commit a53e56e)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2024
@serhiy-storchaka @pitrou @miss-islington
pythongh-75128: Ignore EADDRNOTAVAIL error in asyncio.BaseEventLoop.c…
6833cf4 
…reate_server() (pythonGH-114420)

(cherry picked from commit a53e56e)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 22, 2024

GH-114441 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 22, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 22, 2024

GH-114442 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 22, 2024
serhiy-storchaka added a commit that referenced this pull request Jan 22, 2024
@miss-islington @serhiy-storchaka @pitrou
[3.12] gh-75128: Ignore EADDRNOTAVAIL error in asyncio.BaseEventLoop.…
4bbb9f6 
…create_server() (GH-114420) (GH-114441)

(cherry picked from commit a53e56e)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jan 22, 2024
@miss-islington @serhiy-storchaka @pitrou
[3.11] gh-75128: Ignore EADDRNOTAVAIL error in asyncio.BaseEventLoop.…
acea9d8 
…create_server() (GH-114420) (GH-114442)

(cherry picked from commit a53e56e)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @pitrou @aisk
pythongh-75128: Ignore EADDRNOTAVAIL error in asyncio.BaseEventLoop.c…
5c3f5de 
…reate_server() (pythonGH-114420)

Co-authored-by: Antoine Pitrou <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @pitrou @Glyphack
pythongh-75128: Ignore EADDRNOTAVAIL error in asyncio.BaseEventLoop.c…
e00d614 
…reate_server() (pythonGH-114420)

Co-authored-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @bedevere-bot @pitrou @gvanrossum