Skip to content

GH-114610: Fix pathlib.PurePath.with_stem('') handling of file extensions #114612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2024

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Jan 26, 2024

Raise ValueError if with_stem('') is called on a path with a file extension. Paths may only have an empty stem if they also have an empty suffix.

…e extensions

Raise `ValueError` if `with_stem('')` is called on a path with a file
extension. Paths may only have an empty stem if they also have an empty
suffix.
@barneygale barneygale requested a review from pitrou January 30, 2024 15:07
@barneygale barneygale removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 24, 2024
@barneygale
Copy link
Contributor Author

Skipping backporting as I seem to be the only person who has noticed this bug, and it's possible someone is relying on the old behaviour.

@barneygale barneygale enabled auto-merge (squash) February 24, 2024 19:14
@barneygale barneygale merged commit e3dedea into python:main Feb 24, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…e extensions (python#114612)

Raise `ValueError` if `with_stem('')` is called on a path with a file
extension. Paths may only have an empty stem if they also have an empty
suffix.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…e extensions (python#114612)

Raise `ValueError` if `with_stem('')` is called on a path with a file
extension. Paths may only have an empty stem if they also have an empty
suffix.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
…e extensions (python#114612)

Raise `ValueError` if `with_stem('')` is called on a path with a file
extension. Paths may only have an empty stem if they also have an empty
suffix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant