Skip to content

bpo-35911: add cell constructor #11771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 7, 2019
Merged

bpo-35911: add cell constructor #11771

merged 7 commits into from
Feb 7, 2019

Conversation

pierreglaser
Copy link
Contributor

@pierreglaser pierreglaser commented Feb 6, 2019 •
edited by bedevere-bot
Loading

bpo-35911: Add a cell constructor

This PR adds:

  • a cell.__new__ method, with an optional contents arguments.
  • the cell type in the Lib/types.py module, under the name CellType

Additional docs and tests are also provided.

The rationale behind this PR is explained in detail in the corresponding bpo issue.

https://bugs.python.org/issue35911

@pierreglaser pierreglaser changed the title Bpo 35911 add cell constructor bpo-35911 add cell constructor Feb 6, 2019
@pitrou pitrou changed the title bpo-35911 add cell constructor bpo-35911: add cell constructor Feb 6, 2019
@pitrou pitrou added the type-feature A feature request or enhancement label Feb 6, 2019
pitrou
pitrou approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, looks like a no-brainer to me.
Will wait a bit for other core devs. Feel free to ping in a few days if no other feedback comes.

@pitrou
Copy link
Member

pitrou commented Feb 6, 2019

@1st1 @benjaminp @ncoghlan

ncoghlan
ncoghlan approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May be worth updating https://docs.python.org/3/reference/datamodel.html#the-standard-type-hierarchy to cross-link the new type when it mentions cell_contents.

@pitrou pitrou merged commit df8d2cd into python:master Feb 7, 2019
@pitrou
Copy link
Member

pitrou commented Feb 7, 2019

Thanks @pierreglaser !

@sobolevn sobolevn mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pierreglaser @pitrou @ncoghlan @the-knights-who-say-ni @bedevere-bot