-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-117657: Add TSAN suppressions for the free-threaded build #117736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# This file contains suppressions for the free-threaded build. It contains the | ||
# suppressions for the default build and additional suppressions needed only in | ||
# the free-threaded build. | ||
# | ||
# reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions | ||
|
||
## Default build suppresssions | ||
|
||
race:get_allocator_unlocked | ||
race:set_allocator_unlocked | ||
race:mi_heap_visit_pages | ||
race:_mi_heap_delayed_free_partial | ||
mpage marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Free-threaded suppressions | ||
|
||
race:_add_to_weak_set | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are there GH issues open for all these suppressions? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not yet, working on it :) I want to provide a bit more context (i.e. sample stacktraces + repro instructions) rather than just cutting issues without context. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to start with a simple list in an omnibus issue like #117657 so that there's a single place that people can go look to track who is working on what races. I expect many of the races to have simple fixes, but we can break off the more complex races into their own issues as needed. The work of collecting stacktraces and repros is work that can be split up once this PR is landed and we have a way of coordinating the work. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good. I threw together a quick script to massage the TSAN output from the tests into an index that we can use to look for stacktraces and tests that should reproduce the races. |
||
race:_in_weak_set | ||
race:_Py_IsImmortal | ||
race:_Py_IsOwnedByCurrentThread | ||
race:_PyEval_EvalFrameDefault | ||
race:_PyFunction_SetVersion | ||
race:_PyImport_AcquireLock | ||
race:_PyImport_ReleaseLock | ||
race:_PyInterpreterState_SetNotRunningMain | ||
race:_PyInterpreterState_IsRunningMain | ||
race:_PyObject_GC_IS_SHARED | ||
race:_PyObject_GC_SET_SHARED | ||
race:_PyObject_GC_TRACK | ||
race:_PyType_HasFeature | ||
race:_PyType_Lookup | ||
race:assign_version_tag | ||
race:compare_unicode_unicode | ||
race:delitem_common | ||
race:dictkeys_decref | ||
race:dictkeys_incref | ||
race:dictresize | ||
race:gc_collect_main | ||
race:gc_restore_tid | ||
race:initialize_new_array | ||
race:insertdict | ||
race:lookup_tp_dict | ||
race:PyMember_GetOne | ||
race:PyMember_SetOne | ||
race:new_reference | ||
race:set_contains_key | ||
race:set_inheritable | ||
race:start_the_world | ||
race:tstate_set_detached | ||
race:unicode_hash | ||
race:update_cache | ||
race:update_cache_gil_disabled |
Uh oh!
There was an error while loading. Please reload this page.