Skip to content

GH-121012: Set index to -1 when list iterators become exhausted in tier 2 #121483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jul 8, 2024

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label Jul 8, 2024
@markshannon markshannon merged commit 8ad6067 into python:main Jul 8, 2024
60 checks passed
@miss-islington-app
Copy link

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 8, 2024
… in tier 2 (pythonGH-121483)

(cherry picked from commit 8ad6067)

Co-authored-by: Mark Shannon <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 8, 2024

GH-121494 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 8, 2024
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 3.13 has failed when building commit 2f8919e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1394/builds/216) and take a look at the build logs.
  4. Check if the failure is related to this commit (2f8919e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1394/builds/216

Failed tests:

  • test_smtplib

Failed subtests:

  • test_with_statement_QUIT_failure - test.test_smtplib.SMTPSimTests.test_with_statement_QUIT_failure
  • test_with_statement - test.test_smtplib.SMTPSimTests.test_with_statement

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64/build/Lib/test/test_smtplib.py", line 1243, in test_with_statement_QUIT_failure
    smtp.noop()
    ~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64/build/Lib/smtplib.py", line 525, in noop
    return self.docmd("noop")
           ~~~~~~~~~~^^^^^^^^
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64/build/Lib/smtplib.py", line 432, in docmd
    return self.getreply()
           ~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64/build/Lib/smtplib.py", line 405, in getreply
    raise SMTPServerDisconnected("Connection unexpectedly closed")
smtplib.SMTPServerDisconnected: Connection unexpectedly closed


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64/build/Lib/test/test_smtplib.py", line 1233, in test_with_statement
    code, message = smtp.noop()
                    ~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64/build/Lib/smtplib.py", line 525, in noop
    return self.docmd("noop")
           ~~~~~~~~~~^^^^^^^^
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64/build/Lib/smtplib.py", line 432, in docmd
    return self.getreply()
           ~~~~~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64/build/Lib/smtplib.py", line 405, in getreply
    raise SMTPServerDisconnected("Connection unexpectedly closed")
smtplib.SMTPServerDisconnected: Connection unexpectedly closed

@markshannon markshannon deleted the fix-121012 branch July 9, 2024 10:41
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants