Skip to content

gh-121497: Make Pyrepl respect correctly the history with input hook set #121498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2024
Merged

gh-121497: Make Pyrepl respect correctly the history with input hook set #121498

merged 1 commit into from
Jul 13, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 8, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 8, 2024
Closed
@pablogsal pablogsal mentioned this pull request Jul 10, 2024
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal pablogsal enabled auto-merge (squash) July 13, 2024 09:19
@pablogsal pablogsal merged commit 4e36dd7 into python:main Jul 13, 2024
41 checks passed
@pablogsal pablogsal deleted the input_hook branch July 13, 2024 09:42
@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Jul 13, 2024
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2024
@pablogsal @miss-islington
pythongh-121497: Make Pyrepl respect correctly the history with input…
85d7873 
… hook set (pythonGH-121498)

(cherry picked from commit 4e36dd7)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 13, 2024

GH-121703 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 13, 2024
pablogsal added a commit that referenced this pull request Jul 13, 2024
@miss-islington @pablogsal
[3.13] gh-121497: Make Pyrepl respect correctly the history with inpu…
62572f1 
…t hook set (GH-121498) (#121703)

gh-121497: Make Pyrepl respect correctly the history with input hook set (GH-121498)
(cherry picked from commit 4e36dd7)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@ambv ambv added the topic-repl Related to the interactive shell label Jul 13, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@pablogsal @estyxx
pythongh-121497: Make Pyrepl respect correctly the history with input…
9d91757 
… hook set (python#121498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @serhiy-storchaka @ambv