gh-122170: Fix interpreter exiting due to ValueError from os.stat for too long filename on Windows
#122175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in linecache.updatecache().
…che.updatecache(), add test.
picnixz
reviewed
Jul 23, 2024
| @@ -98,7 +98,7 @@ def updatecache(filename, module_globals=None): | |||
| fullname = filename | |||
| try: | |||
| stat = os.stat(fullname) | |||
| except OSError: | |||
| except (OSError, ValueError): | |||
There was a problem hiding this comment.
This one should not be suppressed on Unix platforms.
| @@ -280,6 +280,10 @@ def test_loader(self): | |||
| self.assertEqual(linecache.getlines(filename, module_globals), | |||
| ['source for x.y.z\n']) | |||
|
|
|||
| @unittest.skipUnless(support.MS_WINDOWS, "Test only relevant in Windows.") | |||
| def test_filename_too_long(self): | |||
| self.assertEqual(linecache.updatecache("s" * 999999), []) | |||
There was a problem hiding this comment.
Also check checkcache (which I forgot on my branch).
|
Closing due to @picnixz's version being more complete and polished, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the interpreter exiting on Windows in 3.13.0b4 and main due to
ValueError: stat: path too long for Windowsbeing raised byos.stat()inupdatecache()in linecache.py when trying to print a traceback with a too long filename.