Skip to content

GH-121634: have wasi.py accept the host target triple as an argument #123030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Aug 15, 2024

@brettcannon brettcannon self-assigned this Aug 15, 2024
@brettcannon brettcannon added the needs backport to 3.13 bugs and security fixes label Aug 15, 2024
@brettcannon brettcannon merged commit b15b81e into python:main Aug 15, 2024
44 checks passed
@brettcannon brettcannon deleted the wasi-host-triple branch August 15, 2024 17:30
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2024
…rgument (pythonGH-123030)

(cherry picked from commit b15b81e)

Co-authored-by: Brett Cannon <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 15, 2024

GH-123042 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 15, 2024
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 3.x has failed when building commit b15b81e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1565/builds/112) and take a look at the build logs.
  4. Check if the failure is related to this commit (b15b81e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1565/builds/112

Failed tests:

  • test_socket
  • test_smtplib

Failed subtests:

  • test_with_statement - test.test_smtplib.SMTPSimTests.test_with_statement
  • test_idna - test.test_socket.GeneralModuleTests.test_idna

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_smtplib.py", line 1233, in test_with_statement
    code, message = smtp.noop()
                    ~~~~~~~~~^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/smtplib.py", line 523, in noop
    return self.docmd("noop")
           ~~~~~~~~~~^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/smtplib.py", line 430, in docmd
    return self.getreply()
           ~~~~~~~~~~~~~^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/smtplib.py", line 403, in getreply
    raise SMTPServerDisconnected("Connection unexpectedly closed")
smtplib.SMTPServerDisconnected: Connection unexpectedly closed


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_socket.py", line 1718, in test_idna
    socket.gethostbyname_ex(domain)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
socket.gaierror: [Errno -2] Name or service not known


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_socket.py", line 1717, in test_idna
    socket.gethostbyname(domain)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^
socket.gaierror: [Errno -2] Name or service not known

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
brettcannon added a commit that referenced this pull request Oct 10, 2024
…argument (GH-123030) (GH-123042)

GH-121634: have `wasi.py` accept the host target triple as an argument (GH-123030)
(cherry picked from commit b15b81e)

Co-authored-by: Brett Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants