Skip to content

gh-123275: Add tests for PYTHON_GIL=1 and -Xgil=1 #123754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Sep 6, 2024

cc @corona10

Maybe we should merge #123753 and then backport this to 3.13 right after?

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 6, 2024
@corona10
Copy link
Member

corona10 commented Sep 6, 2024

Maybe we should merge #123753 and then backport this to 3.13 right after?

Yeah I will.

@ZeroIntensity
Copy link
Member Author

This needs skip news

@corona10 corona10 changed the title gh-123275: Hotfix: add tests for PYTHON_GIL=1 and -Xgil=1 gh-123275: Add tests for PYTHON_GIL=1 and -Xgil=1 Sep 6, 2024
@corona10 corona10 self-assigned this Sep 6, 2024
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 enabled auto-merge (squash) September 6, 2024 00:58
@corona10 corona10 added the needs backport to 3.13 bugs and security fixes label Sep 6, 2024
@corona10 corona10 merged commit fe24b71 into python:main Sep 6, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2024
…-123754)

(cherry picked from commit fe24b71)

Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 6, 2024

GH-123755 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 6, 2024
@ZeroIntensity ZeroIntensity deleted the fix-xgil-1-tests branch September 6, 2024 01:16
corona10 pushed a commit that referenced this pull request Sep 6, 2024
…) (gh-123755)

gh-123275: Add tests for `PYTHON_GIL=1` and `-Xgil=1` (gh-123754)
(cherry picked from commit fe24b71)

Co-authored-by: Peter Bierma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants