gh-124248: Fix crash in struct when processing 0p fields #124251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
reviewed
Sep 19, 2024
vstinner
added
needs backport to 3.12
|
Thanks @brianschubert for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 20, 2024
…nGH-124251) (cherry picked from commit 63f1960) Co-authored-by: Brian Schubert <[email protected]>
|
GH-124277 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 20, 2024
…nGH-124251) (cherry picked from commit 63f1960) Co-authored-by: Brian Schubert <[email protected]>
|
GH-124278 is a backport of this pull request to the 3.12 branch. |
|
Merged, thanks for the bug report and the fix! |
vstinner
pushed a commit
that referenced
this pull request
Sep 20, 2024
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
Yhg1s
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-124248.
Adds special handling for the case when
code->sizeis 0 before attempting to decrementcode->sizeor read the first byte underres.After this change,
0pshould behave like0s.