Skip to content

gh-124609: Fix _Py_ThreadId for Windows builds using MinGW #124663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2024
Merged

gh-124609: Fix _Py_ThreadId for Windows builds using MinGW #124663

merged 4 commits into from
Sep 27, 2024

Conversation

tonyroberts
Copy link
Contributor

@tonyroberts tonyroberts commented Sep 27, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 27, 2024
Closed
@tonyroberts tonyroberts changed the title gh-124609: Fix _Py_ThreadId for Windows builds using GCC [3.13] gh-124609: Fix _Py_ThreadId for Windows builds using GCC Sep 27, 2024
@ZeroIntensity ZeroIntensity changed the title [3.13] gh-124609: Fix _Py_ThreadId for Windows builds using GCC gh-124609: Fix _Py_ThreadId for Windows builds using GCC Sep 27, 2024
@ZeroIntensity
Copy link
Member

(FWIW, the main branch is 3.14, not 3.13. Code goes into 3.13 via backports.)

ZeroIntensity
ZeroIntensity previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine, there's nothing that concerns me here.

@ZeroIntensity ZeroIntensity added the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
@tonyroberts
Copy link
Contributor Author

Thanks @ZeroIntensity. Do I need to submit another PR into a 3.13 branch, or will that happen after this is merged?

@ZeroIntensity
Copy link
Member

The bot will create a 3.13 PR automatically :)

zooba
zooba reviewed Sep 27, 2024
View reviewed changes
@ZeroIntensity ZeroIntensity dismissed their stale review September 27, 2024 13:15

I forgot, this needs a NEWS entry.

@ZeroIntensity
Copy link
Member

ZeroIntensity commented Sep 27, 2024 •
edited
Loading

Sorry, this needs a blurb entry, I didn't see that in my initial review. Could you add one?

@tonyroberts tonyroberts changed the title gh-124609: Fix _Py_ThreadId for Windows builds using GCC gh-124609: Fix _Py_ThreadId for Windows builds using MinGW Sep 27, 2024
@tonyroberts tonyroberts requested a review from zooba September 27, 2024 13:37
@zooba
Copy link
Member

zooba commented Sep 27, 2024

__MINGW32__ seems like the right level to me, yeah. I'll let Sam finish up the PR with you (unless he really doesn't want to).

picnixz
picnixz reviewed Sep 27, 2024
View reviewed changes
@picnixz picnixz self-requested a review September 27, 2024 16:28
colesbury
colesbury approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Tony

@colesbury colesbury enabled auto-merge (squash) September 27, 2024 18:51
@colesbury colesbury merged commit 0881e2d into python:main Sep 27, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @tonyroberts for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2024
@tonyroberts @miss-islington
pythongh-124609: Fix _Py_ThreadId for Windows builds using MinGW (pyt…
0071536 
…honGH-124663)

(cherry picked from commit 0881e2d)

Co-authored-by: Tony Roberts <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124698 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
@miss-islington @tonyroberts
[3.13] gh-124609: Fix _Py_ThreadId for Windows builds using MinGW (GH…
4618c0e 
…-124663) (#124698)

gh-124609: Fix _Py_ThreadId for Windows builds using MinGW (GH-124663)
(cherry picked from commit 0881e2d)

Co-authored-by: Tony Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@picnixz picnixz picnixz approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_Py_ThreadId() fails when compiled using GCC on Windows
5 participants
@tonyroberts @ZeroIntensity @zooba @colesbury @picnixz