-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-125984: fix UAF on fut->fut_{callback,context}0
due to an evil loop.__getattribute__
#126003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kumaraditya303
merged 3 commits into
python:main
from
picnixz:fix/future-uaf-head-callback-125984
Oct 27, 2024
Merged
gh-125984: fix UAF on fut->fut_{callback,context}0
due to an evil loop.__getattribute__
#126003
kumaraditya303
merged 3 commits into
python:main
from
picnixz:fix/future-uaf-head-callback-125984
Oct 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UAFs (on `fut->fut_callback0` and on `fut->fut_context0`) can be triggered if the future's event loop implements an evil `__getattribute__`.
fut->fut_{callback,context}0
due an evil loop.__getattribute__
fut->fut_{callback,context}0
due to an evil loop.__getattribute__
picnixz
commented
Oct 26, 2024
asvetlov
approved these changes
Oct 27, 2024
kumaraditya303
approved these changes
Oct 27, 2024
Thanks @picnixz for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 27, 2024
… due to an evil `loop.__getattribute__` (pythonGH-126003) (cherry picked from commit f819d43) Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 27, 2024
… due to an evil `loop.__getattribute__` (pythonGH-126003) (cherry picked from commit f819d43) Co-authored-by: Bénédikt Tran <[email protected]>
GH-126043 is a backport of this pull request to the 3.13 branch. |
GH-126044 is a backport of this pull request to the 3.12 branch. |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
… due to an evil `loop.__getattribute__` (python#126003)
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
… due to an evil `loop.__getattribute__` (python#126003)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal PoCs:
and
Note that depending on how the PoC is written, the crash may happen at interpreter shutdown instead. The above PoCs are a bit different from the original ones and from the ones in the tests though, but I've confirmed that without the ownership transfer, all PoCs crash.
cc @Nico-Posada
fut->fut_{callback,context}0
with evil__getattribute__
in_asynciomodule.c
#125984