Skip to content

gh-126911: Update credits output #126913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 18, 2024
Merged

gh-126911: Update credits output #126913

merged 6 commits into from
Nov 18, 2024

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Nov 16, 2024 •
edited by bedevere-app bot
Loading

Trivial change updating name of Python Foundation.

@ghost
Copy link

ghost commented Nov 16, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 16, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Nov 16, 2024
Closed
@hugovk
Copy link
Member

hugovk commented Nov 16, 2024

Thanks for the suggestion, but I don't think we should erase their contribution and credit because they had dot com in their name, and the corresponding website is no longer up.

BeOpen.com also has history relating to licensing:

https://docs.python.org/3/license.html

Trivial change updating name of Python Foundation.

See the history page above, the PSF isn't the same as BeOpen.com with a new name.

@hugovk hugovk added the pending The issue will be closed if no feedback is provided label Nov 16, 2024
@StanFromIreland
Copy link
Contributor Author

@hugovk

My mistake I have updated my commit to include BeOpen.

terryjreedy
terryjreedy requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with 2 tweaks.

@bedevere-app
Copy link

bedevere-app bot commented Nov 17, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@terryjreedy terryjreedy changed the title gh-126911: Update credits output (Trivial Change) gh-126911: Update credits output Nov 17, 2024
@terryjreedy terryjreedy added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 17, 2024
@terryjreedy
Copy link
Member

Hugo: I am not sure whether changing 'BeOpen.com' to 'BeOpen' is proper or whether '.com' is part of the name, as opposes to url. Even if '.com' was part of the name, the fact that 'BeOpen.com' in the browser resolves to now unrelated 'beopen.com' suggest that deleteing '.com' is a good idea. I am letting you decide and merge.

Stan: the commit message one adds is intended to be put above, not below, the boilerplate comment. Much easier to edit when above.

encukou
encukou reviewed Nov 18, 2024
View reviewed changes
@hugovk hugovk removed the pending The issue will be closed if no feedback is provided label Nov 18, 2024
hugovk
hugovk approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, "BeOpen.com" was the full name. It was from the dotcom bubble days, and they've long been out of business (as is visible from the new owners of the domain).

We should keep "BeOpen.com" for the copyright and licence, but I thinks it's fine to use a shorter version here in the REPL credits.

@hugovk
Copy link
Member

hugovk commented Nov 18, 2024

@StanFromIreland Tip for next time, we prefer not to rebase branches and force push in this repo, thanks!

@hugovk hugovk merged commit 8fe1926 into python:main Nov 18, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 18, 2024
@StanFromIreland @encukou
@blurb-it @terryjreedy @hugovk @miss-islington
pythongh-126911: Update credits output (pythonGH-126913)
de4675b 
(cherry picked from commit 8fe1926)

Co-authored-by: Stan U. <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 18, 2024

GH-126973 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 18, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 18, 2024
@StanFromIreland @encukou
@blurb-it @terryjreedy @hugovk @miss-islington
pythongh-126911: Update credits output (pythonGH-126913)
4a043e0 
(cherry picked from commit 8fe1926)

Co-authored-by: Stan U. <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 18, 2024

GH-126974 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 18, 2024
@StanFromIreland StanFromIreland deleted the patch-1 branch November 18, 2024 15:31
hugovk added a commit that referenced this pull request Nov 18, 2024
@miss-islington @StanFromIreland
@encukou @blurb-it @terryjreedy @hugovk
[3.12] gh-126911: Update credits output (GH-126913) (#126974)
126acc1 
Co-authored-by: Stan U <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Nov 18, 2024
@miss-islington @StanFromIreland
@encukou @blurb-it @terryjreedy @hugovk
[3.13] gh-126911: Update credits output (GH-126913) (#126973)
5457561 
Co-authored-by: Stan U <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@StanFromIreland @encukou
@blurb-it @terryjreedy @hugovk @ebonnal
pythongh-126911: Update credits output (python#126913)
9abf992 
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

@hugovk hugovk hugovk approved these changes

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StanFromIreland @hugovk @terryjreedy @encukou