Skip to content

[3.13] gh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow arguments with spaces (GH-127575) #127624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The iOS compiler shims can now accept arguments with spaces.
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-ar
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphoneos${IOS_SDK_VERSION} ar $@
xcrun --sdk iphoneos${IOS_SDK_VERSION} ar "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-clang
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang -target arm64-apple-ios $@
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang -target arm64-apple-ios "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-clang++
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang++ -target arm64-apple-ios $@
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang++ -target arm64-apple-ios "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-cpp
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang -target arm64-apple-ios -E $@
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang -target arm64-apple-ios -E "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-simulator-ar
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} ar $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} ar "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-simulator-clang
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target arm64-apple-ios-simulator $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target arm64-apple-ios-simulator "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-simulator-clang++
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang++ -target arm64-apple-ios-simulator $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang++ -target arm64-apple-ios-simulator "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-simulator-cpp
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target arm64-apple-ios-simulator -E $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target arm64-apple-ios-simulator -E "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/x86_64-apple-ios-simulator-ar
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} ar $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} ar "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/x86_64-apple-ios-simulator-clang
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target x86_64-apple-ios-simulator $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target x86_64-apple-ios-simulator "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/x86_64-apple-ios-simulator-clang++
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang++ -target x86_64-apple-ios-simulator $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang++ -target x86_64-apple-ios-simulator "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/x86_64-apple-ios-simulator-cpp
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target x86_64-apple-ios-simulator -E $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target x86_64-apple-ios-simulator -E "$@"
Loading