-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-128472: Add -skip-funcs
to BOLT options to fix computed goto errors
#128511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Skip BOLT optimization of functions using computed gotos, fixing errors on | ||
build with LLVM 19. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2170,7 +2170,14 @@ if test -z "${BOLT_COMMON_FLAGS}" | |
then | ||
AS_VAR_SET( | ||
[BOLT_COMMON_FLAGS], | ||
[-update-debug-sections] | ||
[m4_normalize(" | ||
[-update-debug-sections] | ||
|
||
dnl At least LLVM 19.x doesn't support computed gotos in PIC compiled code. | ||
dnl Exclude functions containing computed gotos. | ||
dnl TODO this may be fixed in LLVM 20.x via https://github.com/llvm/llvm-project/pull/120267. | ||
[-skip-funcs=_PyEval_EvalFrameDefault,sre_ucs1_match/1,sre_ucs2_match/1,sre_ucs4_match/1] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now we have reasons to add CI to maintain this list actively. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ref #128515 |
||
")] | ||
) | ||
fi | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.