gh-80642: timeit - make target time of autorange configurable #140283
+80
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- have `timeit` and `repeat` methods (and functions) fall back on `autorange` if the number is set to 0 or None.
…cpython into fix-issue-36461
|
All commit authors signed the Contributor License Agreement. |
Misc/NEWS.d/next/Library/2019-04-25-21-11-37.bpo-36461.TO5YyP.rst
Outdated
Show resolved
Hide resolved
hugovk
reviewed
Oct 18, 2025
hugovk
reviewed
Oct 18, 2025
Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
hugovk
reviewed
Oct 18, 2025
Co-authored-by: Hugo van Kemenade <[email protected]>
|
Previously timeit returned a single value. Now it can return a pair if number is 0. This should be better documented because it coule be breaking existing code (I do not know if 0 was a legit value beforehand). I do not think we should expose the handling of number=0 to the timeit method itself. Or if this is the case we should first determine the number by autorange and then pass it to timeit() for the "real" test. I cannot comment on the PR because the mobile app is not working well so I am only commenting here, but please consider this as me requesting changes. |
Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of PR #12954 with latest main merged in. I also fixed a few issues in the original (it's now consistently called
target_time, there was a float conversion missing, etc.).To quote the original PR:
📚 Documentation preview 📚: https://cpython-previews--140283.org.readthedocs.build/