gh-70546: Document mmap object's __iter__ behavior that differs from that of bytearray. #140284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztane
force-pushed
the
mmap-iterator-behavior-documented
branch
from
548ad51 to
395b9e0
Compare
…tearray. Propose a workaround with a memoryview wrapper.
ztane
force-pushed
the
mmap-iterator-behavior-documented
branch
from
395b9e0 to
981c4e9
Compare
|
If this PR is merged, I think the referenced issue could be also closed (I cannot do it because it still belongs to a mannequin ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#70546 reports that mmap object
__iter__behavior dffers from that ofbytearray. This pr adds a notice that states thatmmapobjects have__iter__that differs from that ofbytearrays and that you can wrap the object inside amemoryviewto work around the difference.