Skip to content

gh-133656: Remove unused import in Lib/zipimport.py #140325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-133656: Remove unused import in Lib/zipimport.py #140325

wants to merge 2 commits into from
+0 −5

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Oct 19, 2025 •
edited by bedevere-app bot
Loading

also drop the import and maybe a tiny performance up(

can skip news

@bedevere-app bedevere-app bot mentioned this pull request Oct 19, 2025
Closed
@StanFromIreland
Copy link
Member

Last usage was removed in 5c6937a

StanFromIreland
StanFromIreland reviewed Oct 19, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On lines 13 and 14 we have two commented out imports that exist since the module's Python re-write. I think we can remove them too.

@yihong0618
fix: apply comments
b880e3f 
Signed-off-by: yihong0618 <[email protected]>
@yihong0618
Copy link
Contributor Author

On lines 13 and 14 we have two commented out imports that exist since the module's Python re-write. I think we can remove them too.

thanks and deleted

@StanFromIreland StanFromIreland changed the title gh-140324: drop useless code in zipimport gh-133656: drop useless code in zipimport Oct 19, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 19, 2025
Open
@StanFromIreland StanFromIreland changed the title gh-133656: drop useless code in zipimport gh-133656: Remove unused import in Lib/zipimport.py Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yihong0618 @StanFromIreland