Skip to content

bpo-39481: Make dataclasses.Field, contextvars.Token, ... #19425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2020
Merged

bpo-39481: Make dataclasses.Field, contextvars.Token, ... #19425

merged 5 commits into from
Apr 14, 2020

Conversation

emmatyping
Copy link
Member

@emmatyping emmatyping commented Apr 7, 2020 •
edited by bedevere-bot
Loading

... mailbox.MailBox, and mailbox._ProxyFile generic.

https://bugs.python.org/issue39481

@emmatyping
Make dataclasses.Field, contextvars.Token, ...
177a13e 
... mailbox.MailBox, and mailbox._ProxyFile generic.
@emmatyping emmatyping requested review from 1st1, ericvsmith and a team as code owners April 7, 2020 23:34
emmatyping
emmatyping commented Apr 7, 2020
View reviewed changes
1st1
1st1 reviewed Apr 8, 2020
View reviewed changes
gvanrossum
gvanrossum reviewed Apr 10, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also another __class_getitem__, for contextvar, in this file. I think that one should also become GenericAlias.

gvanrossum
gvanrossum requested changes Apr 10, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the docstring to be reverted and for the other class_getitem to link to GenericAlias.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@emmatyping
Copy link
Member Author

Sorry for the delay, I'll get to this and #19427 a bit later today.

@emmatyping
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@gvanrossum: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from gvanrossum April 13, 2020 12:22
gvanrossum
gvanrossum approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@gvanrossum gvanrossum merged commit d01628e into python:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emmatyping @bedevere-bot @1st1 @gvanrossum @the-knights-who-say-ni @isidentical