bpo-45505: ZipFile file header optimization #25966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to create a bpo issue and associate it with this PR. https://bugs.python.org |
|
This PR is stale because it has been open for 30 days with no activity. |
data-ux
changed the title
FFY00
approved these changes
Oct 19, 2021
to avoid unneeded IO
corona10
force-pushed
the
zipfile_extra_seek
branch
from
17aa8dd to
13596f9
Compare
corona10
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZipFile file header optimization
The return value from read() is never used, so we can just seek() to avoid unneeded IO.
_SharedFile.read() implementation already assumes the file is seekable, so should be ok?
The change helps performance in use cases where the fileobject given to ZipFile is backed by high latency IO, eg. HTTP range requests.
https://bugs.python.org/issue45505
closes: gh-89668