Skip to content

bpo-44422: threading.Thread reuses the _delete() method #26741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-44422: threading.Thread reuses the _delete() method
The _bootstrap_inner() method of threading.Thread now reuses its
_delete() method rather than accessing _active() directly. It became
possible since _active_limbo_lock became reentrant. Moreover, it no
longer ignores any exception when deleting the thread from the
_active dictionary.
  • Loading branch information
vstinner committed Jun 15, 2021
commit d32b7fca36c4a5e59de07899dd29ed88388ed65c
8 changes: 1 addition & 7 deletions Lib/threading.py
Original file line number Diff line number Diff line change
Expand Up @@ -1010,13 +1010,7 @@ def _bootstrap_inner(self):
except:
self._invoke_excepthook(self)
finally:
with _active_limbo_lock:
try:
# We don't call self._delete() because it also
# grabs _active_limbo_lock.
del _active[get_ident()]
except:
pass
self._delete()

def _stop(self):
# After calling ._stop(), .is_alive() returns False and .join() returns
Expand Down