bpo-45637: Fix cframe-based fallback in the gdb helpers #29515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
reviewed
Nov 10, 2021
| cframe = self._gdbframe.read_var('cframe') | ||
| if cframe is None: | ||
| return None | ||
| frame = PyFramePtr(cframe["current_frame"].dereference()) | ||
| frame = PyFramePtr(cframe["current_frame"]) |
There was a problem hiding this comment.
This seems more correct. What does it fix?
There was a problem hiding this comment.
The pointer that we are getting was wrong. Seems that new versions of gdb still correct this fall and doesn't do anything if is a value and not a pointer, but old versions like the one FreeBSD get garbage
pablogsal
added
skip news
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 3be986e 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
I am landing this as this fixes the FreeBSD buildbot |
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45637