-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-33635: Handling Bad file descriptor in Path.is_file and related. #8542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request You can check yourself Thanks again for your contribution, we look forward to reviewing it! |
@spodym Just need to add the NEWS item. Click on "Details" next to the failed check for instructions on how to use |
@zooba Hi! :) Is there anything more to improve on in this PR? |
@spodym Nope! Sorry for leaving this so long, and thanks for the work! |
GH-8960 is a backport of this pull request to the 3.7 branch. |
…ythonGH-8542) (cherry picked from commit 216b745) Co-authored-by: Przemysław Spodymek <[email protected]>
…H-8542) (cherry picked from commit 216b745) Co-authored-by: Przemysław Spodymek <[email protected]>
In macOS
stat
on some file descriptors will result in bad file descriptor OSError. This PR is guarding agains this exception inis_dir
,is_file
and similar methods.DirEntry.is_dir
can also throw this exception so I have extended_RecursiveWildcardSelector._iterate_directories
with the same error ignoring pattern.https://bugs.python.org/issue33635