-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Docs: replace 'currying' by 'partial function'. #91814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of replacing the current entry, just add a new entry. The concept of "currying" is in the realm of functional programming and is more well known than partial function application. There is some value in mentioning both.
Also, the distinction between them can be viewed as "splitting hairs".
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Currying is not mentioned in the text so the reference is a little pointless. > Currying is related to, but not the same as, partial application. From https://en.wikipedia.org/wiki/Currying. It is better to replace this with link to https://en.wikipedia.org/wiki/Partial_application as that is used in https://docs.python.org/3.8/howto/functional.html#the-functools-module
8e5bfca
to
8a525f1
Compare
New commit follows @rhettinger review: keeping both. FWIW the docs is not mentioning curry-ing anywhere so that was my reason to replace it.
which is the link to wikipedia :-O |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave the current entry as-is and add a new entry for partial function application.
Even if the word isn't used elsewhere in the docs, having the word "curry" present will give search engines a target.
I forgot to push before/after comment of may 11 :-/ #91814 (comment) |
Currying is not mentioned in the text so the reference is a little pointless.
From https://en.wikipedia.org/wiki/Currying.
It is better to replace this with link to https://en.wikipedia.org/wiki/Partial_application as that is used in https://docs.python.org/3.8/howto/functional.html#the-functools-module