Skip to content

Docs: replace 'currying' by 'partial function'. #91814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

clemens-tolboom
Copy link
Contributor

Currying is not mentioned in the text so the reference is a little pointless.

Currying is related to, but not the same as, partial application.

From https://en.wikipedia.org/wiki/Currying.

It is better to replace this with link to https://en.wikipedia.org/wiki/Partial_application as that is used in https://docs.python.org/3.8/howto/functional.html#the-functools-module

@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 22, 2022
@clemens-tolboom clemens-tolboom changed the title Replace 'currying' by 'partial function'. Docs: replace 'currying' by 'partial function'. Apr 22, 2022
@AlexWaygood AlexWaygood requested a review from rhettinger April 26, 2022 15:17
@rhettinger rhettinger removed their request for review May 1, 2022 09:13
Copy link
Contributor

@rhettinger rhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of replacing the current entry, just add a new entry. The concept of "currying" is in the realm of functional programming and is more well known than partial function application. There is some value in mentioning both.

Also, the distinction between them can be viewed as "splitting hairs".

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Currying is not mentioned in the text so the reference is a little pointless.

> Currying is related to, but not the same as, partial application.

From https://en.wikipedia.org/wiki/Currying.

It is better to replace this with link to https://en.wikipedia.org/wiki/Partial_application as that is used in https://docs.python.org/3.8/howto/functional.html#the-functools-module
@clemens-tolboom
Copy link
Contributor Author

New commit follows @rhettinger review: keeping both.

FWIW the docs is not mentioning curry-ing anywhere so that was my reason to replace it.

grep curry -i Doc/howto/functional.rst | wc -l
       1

which is the link to wikipedia :-O

@erlend-aasland erlend-aasland requested a review from rhettinger May 20, 2022 08:07
Copy link
Contributor

@rhettinger rhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave the current entry as-is and add a new entry for partial function application.

Even if the word isn't used elsewhere in the docs, having the word "curry" present will give search engines a target.

@clemens-tolboom
Copy link
Contributor Author

I forgot to push before/after comment of may 11 :-/ #91814 (comment)

@rhettinger rhettinger merged commit b9e956f into python:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants