Skip to content

gh-92063: Enforce types in specialized PRECALL opcodes #92068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 30, 2022
Merged

gh-92063: Enforce types in specialized PRECALL opcodes #92068

merged 8 commits into from
Apr 30, 2022

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde requested a review from markshannon as a code owner April 30, 2022 04:18
@sweeneyde sweeneyde added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 30, 2022
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 30, 2022
@sweeneyde sweeneyde changed the title gh-92063: Check the types of PRECALL_METHOD_DESCRIPTOR_FAST_WITH_KEYWORDS gh-92063: Enforce types in specialized PRECALL opcodes Apr 30, 2022
@sweeneyde sweeneyde added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 30, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit adb1504 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 30, 2022
@sweeneyde
Copy link
Member Author

The single failing buildbot fails on repeated invocations of test_embed.test_finalize_structseq, which is related to #92031

@markshannon
Copy link
Member

@sweeneyde Thanks for fixing this.
Looks good to me.

@markshannon markshannon merged commit 868b1af into python:main Apr 30, 2022
@sweeneyde sweeneyde deleted the check_types branch April 30, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sweeneyde @bedevere-bot @markshannon