GH-94329: Don't raise on excessive stack consumption #94421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
added
needs backport to 3.10
iritkatriel
reviewed
Jun 30, 2022
iritkatriel
approved these changes
Jun 30, 2022
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Sorry, @markshannon, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 30, 2022
…94421) (cherry picked from commit b152bf4) Co-authored-by: Mark Shannon <[email protected]>
|
GH-94446 is a backport of this pull request to the 3.11 branch. |
markshannon
pushed a commit
that referenced
this pull request
Jun 30, 2022
gvanrossum
pushed a commit
to gvanrossum/cpython
that referenced
this pull request
Jun 30, 2022
pablogsal
pushed a commit
that referenced
this pull request
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the compiler to produce code that doesn't use excessive amounts of stack, but we shouldn't limit what we can compile.
This PR allows code like
x0, x1, ..., x4000 = tto compile and run correctly.For 3.12 we want to compile the above code in a way that doesn't use too much stack, but for now let's just accept that we need a lot of stack.