-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-95005: Replace PyAccu with PyUnicodeWriter #95006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
PyAccu was still being used in only two places: the JSON encoder and StringIO. Replace PyAccu with PyUnicodeWriter and remove PyAccu completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only 3 tests failed from test suite. Code is good.
PyAccu was still being used in only two places: the JSON encoder and StringIO. Replace PyAccu with PyUnicodeWriter and remove PyAccu completely.
Which test? |
buildbot/AMD64 Debian seems to have a broken compiler or hardware error. The compiler crashed the last time and now it gets SIGBUS while compiling |
I ran |
I sent a mail to the machine owner, seems unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Overall looks good, I just left nit comment.
Co-authored-by: Dong-hee Na <[email protected]>
PyAccu was still being used in only two places: the JSON encoder and StringIO.
Replace PyAccu with PyUnicodeWriter and remove PyAccu completely.